search

flavorjones / mini_portile

mini_portile and mini_portile2 - Simple autoconf and cmake builder for developers
MIT License
114 stars 51 forks source link

cmake: only use MSYS/NMake generators when available #129

Closed stanhu closed 1 year ago

stanhu commented 1 year ago

When cross-compiling Windows targets with cmake in a Linux environment, the MSYS generator may not be available. Supplying -G MSYS will cause the build to fail.

cmake --help will output the available generators. Before including the -G option, check that the generator is available.

Closes #127

flavorjones commented 1 year ago

@stanhu Thanks for this! I kicked off CI but looks like there are some test failures.

flavorjones commented 1 year ago

This looks OK to me. @stanhu do you want to write a CHANGELOG entry, and then I can merge and cut a point release for you?

stanhu commented 1 year ago

@flavorjones Sure, should I mark this as v2.9.0?

flavorjones commented 1 year ago

Shipped in https://github.com/flavorjones/mini_portile/releases/tag/v2.8.3