Closed mudge closed 5 months ago
@mudge Thanks for this. Ideally I'd like FreeBSD included in the CI matrix. Let me do that in a separate PR and then we can rebase this.
_Edit: that PR is https://github.com/flavorjones/mini_portile/pull/140_
@mudge I've pushed a commit onto this branch that has CI set up on FreeBSD. You can see the pristine state of those CI jobs at #140 which seem to be failing on:
Let's see what happens! :crossed_fingers:
:tada: the unit tests are passing in this PR because you've configured the compiler! whee!
Do you want to try to address the make
issues from test:examples in this PR, too?
I'm not too familiar with make
on FreeBSD but I'm guessing we need to use gmake
instead (which may require installing via pkg install devel/gmake
first)?
As gmake
is not available by default on FreeBSD, I'm not sure how you'd feel about defaulting to that within MiniPortile itself (though I suppose cmake
isn't available out of the box either). I also suppose this would vary between recipes: some might work with BSD make and others with GNU.
As a middle ground, I've added e0de7648d80c1007c8d69316a65f4e2eab48eab2 which explicitly installs devel/gmake
and instructs MiniPortile to use it by setting the MAKE
environment variable to gmake
. This should hopefully get the tests passing but I'll leave it to you whether we want to set to be the default on FreeBSD.
@mudge That's perfect! Thank you for doing that, the bsd job is green: https://github.com/flavorjones/mini_portile/actions/runs/8661982917/job/23757576215?pr=139
I'll merge and cut a release later today!
Just shipped 2.8.6: Release 2.8.6 / 2024-04-14 · flavorjones/mini_portile
As of FreeBSD 10.X, clang is installed as the default compiler with "cc" and "c++" as aliases to "clang" and "clang++" respectively.