search

flavorjones / mini_portile

mini_portile and mini_portile2 - Simple autoconf and cmake builder for developers
MIT License
114 stars 51 forks source link

Add `cxx_cmd` which parallels `cc_cmd` #144

Closed flavorjones closed 5 months ago

flavorjones commented 5 months ago

Add a cxx_cmd. Use it for configuring CMake, removing the logic added in #130 for host-specific binary detection.

Related to #141.

flavorjones commented 5 months ago

@stanhu Do you want to give this branch a try on your projects before I merge, to make sure I'm not breaking anything?

stanhu commented 5 months ago

@flavorjones Sure, I'm running a test with the re2 gem now.

stanhu commented 5 months ago

I tested locally, and the CI runs in https://github.com/mudge/re2/pull/151 look good. The failures are due to not having mini_portile2 available as a gem. We can re-test with a release.

flavorjones commented 5 months ago

@stanhu Thanks for testing! I'll get an RC out this week.

flavorjones commented 4 months ago

@stanhu I just released v2.8.7.rc1. If you're able to run that through re2 CI to confirm it's OK for you then I will cut a final release.

Side note: I'm going to try to set up a downstream CI workflow to test re2, sqlite3, and nokogiri.

Edit: that PR is #146.

stanhu commented 4 months ago

Thanks! I created https://github.com/mudge/re2/pull/153 to test.

Side note: I'm going to try to set up a downstream CI workflow to test re2, sqlite3, and nokogiri.

Awesome, great idea. FYI @mudge

stanhu commented 4 months ago

v2.8.7.rc1 seems to work fine.

flavorjones commented 4 months ago

@stanhu Thank you! The downstream integration tests are live, FYI: https://github.com/flavorjones/mini_portile/actions/runs/9324948020

flavorjones commented 4 months ago

v2.8.7 final is out. Thank you again!