Closed flavorjones closed 5 months ago
@stanhu Do you want to give this branch a try on your projects before I merge, to make sure I'm not breaking anything?
@flavorjones Sure, I'm running a test with the re2 gem now.
I tested locally, and the CI runs in https://github.com/mudge/re2/pull/151 look good. The failures are due to not having mini_portile2
available as a gem. We can re-test with a release.
@stanhu Thanks for testing! I'll get an RC out this week.
@stanhu I just released v2.8.7.rc1. If you're able to run that through re2 CI to confirm it's OK for you then I will cut a final release.
Side note: I'm going to try to set up a downstream CI workflow to test re2, sqlite3, and nokogiri.
Edit: that PR is #146.
Thanks! I created https://github.com/mudge/re2/pull/153 to test.
Side note: I'm going to try to set up a downstream CI workflow to test re2, sqlite3, and nokogiri.
Awesome, great idea. FYI @mudge
v2.8.7.rc1 seems to work fine.
@stanhu Thank you! The downstream integration tests are live, FYI: https://github.com/flavorjones/mini_portile/actions/runs/9324948020
v2.8.7 final is out. Thank you again!
Add a
cxx_cmd
. Use it for configuring CMake, removing the logic added in #130 for host-specific binary detection.Related to #141.