search

flavors / django-graphql-jwt

JSON Web Token (JWT) authentication for Graphene Django
https://django-graphql-jwt.domake.io
MIT License
820 stars 171 forks source link

Add JWT_COOKIE_SAMESITE property to deleted cookie #295

Open Stijn-B opened 2 years ago

Stijn-B commented 2 years ago

To delete a httponly cookie, the server responds with a cookie of which the expiration is in the past (https://stackoverflow.com/a/20320610/3179285)

In case of cross origin requests it's important that the SameSite attribute is also the same so I added this parameter to delete_cookie.

kevinwfhe commented 1 year ago

Any update on this PR?

Stijn-B commented 1 year ago

@kevinwfhe This library seems abandoned. I have been using my fork successfully but am in the process of migrating away from graphene because its ecosystem in general isn't very active

kevinwfhe commented 1 year ago

@kevinwfhe This library seems abandoned. I have been using my fork successfully but am in the process of migrating away from graphene because its ecosystem in general isn't very active

Yea, I think graphene-django hasn't been released with a new version for about a year. I guess will just fork this and use it myself for now. Thank you!