Closed sebastianblunt closed 4 years ago
Absolutely for the docstrings.
Either of the names sound fine to me, I’d personally have a weak preference for SerError
and DeError
.
Thanks, that works. So let's change "DesError" to "DeError" and add the docstrings. I'll merge the PR soon after.
On Thu, Jan 23, 2020, 13:19 Sebastian Blunt notifications@github.com wrote:
Absolutely for the docstrings.
Either of the names sound fine to me, I’d personally have a weak preference for SerError and DeError.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/flavray/avro-rs/pull/104?email_source=notifications&email_token=AALT2BWG4MLT26BRHN6MKEDQ7GKNRA5CNFSM4KHMHYB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJXKVZQ#issuecomment-577678054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALT2BUU7IXCIXF4A4YKR7DQ7GKNRANCNFSM4KHMHYBQ .
Thanks for contributing! :) I'm planning to release a new version as soon as a couple of other PRs close to completion will land.
This is useful for people who use the error handling strategy of defining wrapper Errors around the different kinds of errors that may be expected. Without making the Error types encountered public it's not possible to create new error types that wrap them.
I re-exported the errors renamed, as I'm guessing by current code organization you don't want the de and ser modules public, though that could just as well be done just making everything non-public as
pub(crate)
.