Closed calvinbrown085 closed 4 years ago
I'm not exactly sure what went wrong with the build here..
@poros Do you know what went wrong on the build? It looks like cargo check
worked fine.
I am not really sure what the first error is, perhaps something transient caused by travis? Anyways, I have re-started the build and it fails with compilation errors. Maybe you can try to run make test
locally and see if your branch works on your machine?
It looks like you just forgot to use serde::Serialize;
in the test module of de.rs
, the other two things were deprecation warnings that shouldn't break the stable and nightly builds
@codehearts Thanks! I must have missed that when fixing merge conflicts
Ah, now it looks like cargo fmt
needs to be run on the repo for the build to be happy
@codehearts I will grab this later tonight :)
@calvinbrown085 are you still interested in this PR? It was pretty close to land!
@poros Yes! I will grab this.
@poros Okay I ran cargo fmt
lets see if this passes :)
@poros Anything else here?
Nothing else, thanks :)
This fixes conflicts introduced here. https://github.com/flavray/avro-rs/pull/60
All credit goes to @jdeschenes for implementing the original feature.