search

flavray / avro-rs

Avro client library implementation in Rust
MIT License
169 stars 95 forks source link

[Conflict Fix] Partial Rust Enum Serialization/Deserialization Support #110

Closed calvinbrown085 closed 4 years ago

calvinbrown085 commented 4 years ago

This fixes conflicts introduced here. https://github.com/flavray/avro-rs/pull/60

All credit goes to @jdeschenes for implementing the original feature.

calvinbrown085 commented 4 years ago

I'm not exactly sure what went wrong with the build here..

calvinbrown085 commented 4 years ago

@poros Do you know what went wrong on the build? It looks like cargo check worked fine.

poros commented 4 years ago

I am not really sure what the first error is, perhaps something transient caused by travis? Anyways, I have re-started the build and it fails with compilation errors. Maybe you can try to run make test locally and see if your branch works on your machine?

codehearts commented 4 years ago

It looks like you just forgot to use serde::Serialize; in the test module of de.rs, the other two things were deprecation warnings that shouldn't break the stable and nightly builds

calvinbrown085 commented 4 years ago

@codehearts Thanks! I must have missed that when fixing merge conflicts

codehearts commented 4 years ago

Ah, now it looks like cargo fmt needs to be run on the repo for the build to be happy

calvinbrown085 commented 4 years ago

@codehearts I will grab this later tonight :)

poros commented 4 years ago

@calvinbrown085 are you still interested in this PR? It was pretty close to land!

calvinbrown085 commented 4 years ago

@poros Yes! I will grab this.

calvinbrown085 commented 4 years ago

@poros Okay I ran cargo fmt lets see if this passes :)

calvinbrown085 commented 4 years ago

@poros Anything else here?

poros commented 4 years ago

Nothing else, thanks :)