Deprecate ToAvro in favor of From<T> for Value impls

flavray / avro-rs

Avro client library implementation in Rust

MIT License

169 stars 95 forks source link

Deprecate ToAvro in favor of From<T> for Value impls #137

Closed cpcloud closed 4 years ago

cpcloud commented 4 years ago

This PR deprecates the ToAvro trait in favor of From<T> for Value implementations.

ToAvro is now implemented in terms of From, along with a deprecation warning to any code that uses it from the next release onward.

poros commented 4 years ago

Oh man, this has been in the TODO list for the crate for quite some time, thanks! I'll have a look at the PR as soon as I have a bit of time, but I am very up for the change.

poros commented 4 years ago

Code looks great! Thanks a bunch and I appreciate you added a deprecation warning for the ToAvro trait. Merging it :)