search

flavray / avro-rs

Avro client library implementation in Rust
MIT License
169 stars 95 forks source link

allow Value::Bytes to be assigned to Schema::Fixed ... #171

Closed dgrijalva-squire closed 3 years ago

dgrijalva-squire commented 3 years ago

... as long as the length matches. This seems needed to enable Serde and serde-bytes to provide Fixed values.

dgrijalva-squire commented 3 years ago

Not sure why the tests failed. The all pass when I run locally. It looks like it was an issue with the test system rather than the code.

poros commented 3 years ago

Hello, sorry for the late reply!

Could you try to rebase on master and to run cargo fmt? We had clippy failing in master, but now it should be fixed, while cargo fmt seems to fail for your branch.

poros commented 3 years ago

Hello! As of today, I am stepping down as a maintainer of this library for a while (see #174). Please ping @flavray from now on. Thanks again for your contribution :)

dgrijalva-squire commented 3 years ago

@flavray merge and formatted, as requested.

tests pass locally. we'll see if they are able to run now. there was some permissions error last time.

flavray commented 3 years ago

v0.13.0 has just been released with this change. 🙂