de: add missing matches to deserialize_any union and string/map

flavray / avro-rs

Avro client library implementation in Rust

MIT License

169 stars 95 forks source link

de: add missing matches to deserialize_any union and string/map #200

Closed ultrabug closed 2 years ago

ultrabug commented 2 years ago

this fixes deserialization of complex avro schemas when using from_value::

In my quest for deserializing to a struct for ease of use I found myself digging into avro-rs code to find out that my problems were due to the fact that the avro-rs crate is missing deserialization cases which my schema need :)

Here is how I fixed it, I hope this helps :+1:

ultrabug commented 2 years ago

Thanks @martin-g I guess that's why none of my comments / ask for help were heard...

@flavray may I suggest you make this fact a bit clearer please?

mention it on top of the README ?
disable issues/PR ?
close https://github.com/flavray/avro-rs/issues/189 with a real message stating that it's been moved away ?

That would make my frustrating experience beneficial to others :+1:

Meanwhile, I'm gonna send the PR to the right project thanks to @martin-g

ultrabug commented 2 years ago

Moved to https://github.com/apache/avro/pull/1368

flavray commented 2 years ago

Apologies for the confustion @ultrabug , I've updated the repository. Thank you for your contribution! 🙂