search

flazz / vim-colorschemes

one colorscheme pack to rule them all!
3.44k stars 630 forks source link

Tomorrow-Night was improperly updated #157

Closed ichitera closed 5 years ago

ichitera commented 6 years ago

After 90b25265feab2f51cd6d821a3b6b173df7759730, many colors of Tomorrow-Night were changed. The colors seem not to be included in the original Tomorrow-Night palette, so I thought that 90b25265feab2f51cd6d821a3b6b173df7759730 improperly updated Tomorro-Night.

before 90b25265feab2f51cd6d821a3b6b173df7759730: old

after 90b25265feab2f51cd6d821a3b6b173df7759730: new

NOTE:

jhawksley commented 6 years ago

I'm also having trouble with this theme using Plugged/nvim. May be unrelated, but anyway:

Error detected while processing /<me>/.config/nvim/plugged/vim-colorschemes/colors/Tomorrow-Night.vim:
line   44:
E122: Function <SNR>16_grey_number already exists, add ! to replace it
line   53:
E122: Function <SNR>16_grey_level already exists, add ! to replace it
line   64:
E122: Function <SNR>16_grey_colour already exists, add ! to replace it
line   79:
E122: Function <SNR>16_rgb_number already exists, add ! to replace it
line   88:
E122: Function <SNR>16_rgb_level already exists, add ! to replace it
line   93:
E122: Function <SNR>16_rgb_colour already exists, add ! to replace it
line  129:
E122: Function <SNR>16_colour already exists, add ! to replace it
line  139:
E122: Function <SNR>16_rgb already exists, add ! to replace it
gfontenot commented 6 years ago

Lucius was improperly updated as well. The update changed a bunch of the colors, and removed the helper functions for setting the color variants. Any chance of reverting that commit?

taylorthurlow commented 5 years ago

Also having the same issue with Tomorrow-Night.

tbodt commented 5 years ago

@flazz please merge #160 to fix this regression

thejohnfreeman commented 5 years ago

@flazz or @ichitera , you can mark this closed now.

gfontenot commented 5 years ago

This is fixed for Tomorrow Night, but the same change broke countless other themes. Tomorrow Night is just the most visible one that broke. The correct change to fix this issue is almost certainly to revert 90b25265feab2f51cd6d821a3b6b173df7759730

tbodt commented 5 years ago

If your current colorscheme broke as a result of that commit I would recommend installing it from its original source, that way it won't break and it can be updated by the creator.

ichitera commented 5 years ago

@thejohnfreeman, thank you for the notification. I confirmed that Tomorrow-Night was back to the original. Also, @tbodt, thank you for the pull-request.

Although @gfontenot reported that other themese also were broken, I will close this issue because this issue mentioned only Tomorrow-Night, and this colorscheme was fixed.

@gfontenot or someone, please create a new issue if you find other broken colorschemes. I did not check the other colorschemes, and I did not encounter other broken colorschemes.