flcdrg / au-packages

David's Chocolatey Automatic Packages
MIT License
18 stars 55 forks source link

Added KeyFile support. #33

Closed rlpowell closed 6 years ago

rlpowell commented 6 years ago

Here's the command lines I used for testing, after clearing all "Tracker Software" stuff out of the registry to kill the licenses (see https://forum.tracker-software.com/viewtopic.php?f=62&t=31115&p=125437 ):

choco install PDFXchangeEditor -dv -s .

Checked, no license. Removed with "choco uninstall".

choco install PDFXchangeEditor -dv -s . --params "/KeyFile C:\Users\rlpowell\Dropbox\Windows_Automation_Secrets\PDFXChangeEditor.xcvault"

Errors out as intended:

ERROR: KeyFile needs a colon-separated argument; try something like this: --params "/KeyFile:C:\Users\foo\Temp\PDFXChangeEditor.xcvault".
 at <ScriptBlock>, C:\ProgramData\chocolatey\lib\PDFXchangeEditor\tools\chocolateyInstall.ps1: line 109
at <ScriptBlock>, C:\ProgramData\chocolatey\helpers\chocolateyScriptRunner.ps1: line 48
at <ScriptBlock>, <No file>: line 1

Lastly:

choco install PDFXchangeEditor -dv -s . --params "/KeyFile:C:\Users\rlpowell\Dropbox\Windows_Automation_Secrets\PDFXChangeEditor.xcvault"

And license is in place as intended.

rlpowell commented 6 years ago

Oh, a potentially major issue here: I didn't bump the version number, because the underlying version hasn't changed. Not sure what to do about that; can you upload something with the same version to Chocolatey?

flcdrg commented 6 years ago

Thanks!

This will be included in the next package version

flcdrg commented 6 years ago

Resolves #32

flcdrg commented 6 years ago

Just saw your second comment - so either wait patiently for a new version of the software to come out.. OR I can manually submit a new version that changes the last digit.

In this case I'd rather wait, as they do occasionally release new versions that just change the last digit anyway (the current release 7.0.325.1 is an example of that). If I push out 7.0.325.2 then we'll have problems if Tracker then publish a real 7.0.325.2

rlpowell commented 6 years ago

I think I can be patient. :) Thanks for offering, though.

On Tue, Jun 19, 2018 at 05:31:38PM -0700, David Gardiner wrote:

Just saw your second comment - so either wait patiently for a new version of the software to come out.. OR I can manually submit a new version that changes the last digit.

In this case I'd rather wait, as they do occasionally release new versions that just change the last digit anyway (the current release 7.0.325.1 is an example of that). If I push out 7.0.325.2 then we'll have problems if Tracker then publish a real 7.0.325.2

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/flcdrg/au-packages/pull/33#issuecomment-398586953