search

fle-internal / ka-lite-central

KA Lite central server code (wraps the ka-lite repository and adds features)
https://kalite.learningequality.org/
4 stars 20 forks source link

Do not pin six, it's part of ka-lite requirement #314

Closed benjaoming closed 5 years ago

benjaoming commented 5 years ago

Still need to figure out:

ERROR: ka-lite 0.17.6b4 has requirement requests==2.11.1, but you'll have requests 2.22.0 which is incompatible.
benjaoming commented 5 years ago

The incompatible requests version is coming from responses==0.3.0

But I guess requests should have been bumped in upstream KA Lite as well because of many security issues.

codecov-io commented 5 years ago

Codecov Report

Merging #314 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #314   +/-   ##
=======================================
  Coverage     79.3%   79.3%           
=======================================
  Files           60      60           
  Lines         2228    2228           
=======================================
  Hits          1767    1767           
  Misses         461     461

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 480594f...f16a6d5. Read the comment docs.

benjaoming commented 5 years ago

Issue with requests is being fixed here: https://github.com/learningequality/ka-lite/pull/5608