fleaflet / flutter_map

A versatile mapping package for Flutter. Simple and easy to learn, yet completely customizable and configurable, it's the best choice for mapping in your Flutter app.
https://pub.dev/packages/flutter_map
BSD 3-Clause "New" or "Revised" License
2.74k stars 861 forks source link

Hosting flutter_map plugins in fleaflet GitHub organization #932

Closed Xennis closed 3 years ago

Xennis commented 3 years ago

Dear flutter_map maintainers,

I liked flutter_map and its extensibility via plugins. A drawback is that most plugins are spread across a lot of private GitHub accounts and are often maintained by just one person. A lot of forking happens to patch plugins for example to make them compatible to the latest flutter_map version or to each other. Further on it sometimes take quite some time before merge requests are merged because of the few maintainers.

I'm the maintainer of https://github.com/Xennis/flutter_map_location . I'm getting more and more issues and pull requests and would like to work together with others on the plugin; including giving some people more permissions.

I think it would boost flutter_map if plugins are maintained within the same GitHub organization (of course on voluntary basis). An great example is https://github.com/fluttercommunity that maintainers a lot of high quality plugins and where each plugin has a clear maintainer but other people can easily make adjustments as well.

I would be open to transfer my repo to fleaflet and continue there my work there with together others.

What do you think about that?

Regards Xennis

TheOneWithTheBraid commented 3 years ago

As a contributor of flutter_map_location, I definitely like the idea of having a unified flutter_map community.

ibrierley commented 3 years ago

I agree something would be useful. I've written 4 plugins and not bothered making a PR for the main Readme, but I know others may find some useful.

The examples mentioned feel a bit "listy" (but that's probably my ignorance), although maybe the community side is interesting, but I'm not quite sure what actual community is there or how that works ?

For what it's worth I find this useful for Leaflet https://leafletjs.com/plugins.html and have referred to it quite a bit when searching, and if nothing else a layout like that would be beneficial...is there something that would meet several criteria, allowing easy edit via multiple changing users (no single owner), useful layout, and maybe community ?

Ian

On Wed, Jun 9, 2021 at 9:44 PM The one with the braid | Dфҿ mit dem Zopf < @.***> wrote:

As a contributor of flutter_map_location, I definitely like the idea of having a unified flutter_map community.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fleaflet/flutter_map/issues/932#issuecomment-858087290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5YN5LKNMGKESB2R2KX64LTR7HCPANCNFSM46MXOEJA .

JaffaKetchup commented 3 years ago

Yeah, that sounds good @Xennis, especially as this project has it's own user space anyway!

JaffaKetchup commented 3 years ago

@ibrierley Wow, you totally should make a PR if this doesn't happen, because I just found two of your plugins to do with dragging extremely useful! Thanks 👍

ibrierley commented 3 years ago

No problem! Btw on most there's null safety branches there, just I haven't properly tested them yet.

Is there any overlap with documentation i.e https://github.com/fleaflet/flutter_map/discussions/927 ? Can't make my mind up, just like things not too fragmented.

What exactly is fleaflet ? Hadn't even pondered this too much :D.

Just another thought, what about the flutter_map wiki. If it was enabled I think you can allow public editing (as long as they have a git account). It's mentioned in the docs discussion. Could it be a way to go, or does it need a more community aspect and repos under one umbrella (and would people want to do that?)

JaffaKetchup commented 3 years ago

Yeah I found the null-safety branches eventually, and they seem to work for me! Also about the wiki, the issue is you can't make a PR for a wiki, so an external wiki or Pages would be better.

I think a good solution would be a community wiki, under a different repo within fleaflet (eg. flutter_map_docs), and all the important plugins could be under fleaflet (eg. plugin_draggable_marker)?

PS. fleaflet stands for Flutter Leaflet (which is a mapping library for JavaScript)

ibrierley commented 3 years ago

Do you need PRs when anyone can edit it though ? i.e https://docs.github.com/en/communities/documenting-your-project-with-wikis/changing-access-permissions-for-wikis assuming Jon or whoever would be ok with that...

The fleaflet question, I think I was more meaning who owns it etc, rather than what it stands for. Is it a github organisation that's been set up. If you transfer one of your repos to it, and then something happens to them, what happens ? I'd probably be very hesitant to transfer a repo to it

JaffaKetchup commented 3 years ago

Yeah I'm not sure what would happen, we'd have to double check. I guess of 'Jon' could start the wiki, then we can all contribute without PR, but he will need to start it. Maybe we could setup a test repo to see what happens?

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 3 years ago

This issue was closed because it has been stalled for 5 days with no activity.