search

fleaz / CptHook

Receive webhooks from different applications and post them to IRC channels
MIT License
17 stars 8 forks source link

Make channel mapping more robust #31

Closed fooker closed 4 years ago

fooker commented 5 years ago

This solves the problem of having dots in the channel name (fixes #30).

fleaz commented 5 years ago

This would be a breaking change due to the changed config file.

According to this issue using UnmarshalKey instead of Unmarshal also avoids the problem. Maybe use this way instead so we don't have to break the config layout?

fleaz commented 4 years ago

Since it's still not fixed in upstream I changed the code to simply use UnmarshalKey instead of Unmarshal which seems to fix the problem.

@fooker Can you take a look at 4dd163e45fc17643138abc19465657ff6d06283a ? Then I would prefer this change instead of this PR since we can keep the old config structure.

fleaz commented 4 years ago

Closed in favour of 4dd163e45fc17643138abc19465657ff6d06283a