search

fledge-iot / fledge-service-dispatcher

Dispatcher service is responsible for dispatching control messages between Fledge services.
0 stars 0 forks source link

FOGL-7103: Modified to restart dispatcher service in case of SIGTERM s… #31

Closed gnandan closed 1 year ago

gnandan commented 1 year ago

…ignal

Signed-off-by: nandan nandan.ghildiyal@gmail.com

gnandan commented 1 year ago

The idea we discussed was to let the service stop, but just not unregister it. This way the core would restart it and we would have a fresh binary. As it is we have a problem because the core will send a SIGTERM to stop it if it does not respond to the API request to stop. Now we end up restarting it and would have a zombie server left behind.

Hi Mark Here I am not blocking service stop. when we call restart method it only set m_restartRequest = true and calls stop function to let the service stop. Flag m_restartRequest = true just not unregister the service when it's stopped.

gnandan commented 1 year ago

The idea we discussed was to let the service stop, but just not unregister it. This way the core would restart it and we would have a fresh binary. As it is we have a problem because the core will send a SIGTERM to stop it if it does not respond to the API request to stop. Now we end up restarting it and would have a zombie server left behind.

Hi Mark Here I am not blocking service stop. when we call restart method it only set m_restartRequest = true and calls stop function to let the service stop. Flag m_restartRequest = true just not unregister the service when it's stopped.

Hi Mark, I modified the code in a way that process doesn't call to internal restart. Instead it's just stopping service to get unregistered from core in case of SIGTERM signal, this way now process is getting restarted by the core.