search

fledge-iot / fledge-service-dispatcher

Dispatcher service is responsible for dispatching control messages between Fledge services.
0 stars 0 forks source link

Control pipelines: Filter order is randomized at creation #53

Closed FlorentP42 closed 9 months ago

FlorentP42 commented 11 months ago

Describe the bug When creating a control pipeline, the order of the filters is not always respected (sometimes order gets inverted).

To Reproduce Steps to reproduce the behavior:

  1. Create a north service.
  2. Create a south service.
  3. Create a control pipeline between those services with two filters FilterA and FilterB.
  4. Verify the order of the filters displayed in the GUi (expected: FilterA, FilterB).
  5. Delete the pipeline above.
  6. Repeat steps from step 4 about 10 times.
  7. Notice that sometimes, the pipeline is created with the filters put in the wrong order (FilterB, FilterA).

Expected behavior The filters in a control pipeline are always respecting the order provided at creation.

Additional context N/A

FlorentP42 commented 9 months ago

Tested on Fledge 2.3.0-47 nightly, now they appear to be always in alphabetic order, which is also wrong as they do not respect the order provided at creation : image Produces : image Filter order should be aaa4, aaa3

MarkRiddoch commented 9 months ago

The issue has been identified and a fix is currently in testing for this.

FlorentP42 commented 9 months ago

@MarkRiddoch I tested this again on Fledge 2.3.0-73 and it seems to be fixed (even if it is hard to tell as it was occuring randomly) but with many attempts I could not reproduce it. Was the fix mentionned above included in that nightly?

ashish-jabble commented 9 months ago

@FlorentP42 Thanks for the confirmation.

Was the fix mentionned above included in that nightly?

yes nightly on fledge repository. The issue at Fledge Admin Control pipeline API as it was not preserving the filter order. That also means no fix for this repository.

MarkRiddoch commented 9 months ago

The fix for this is now in the develop branch