search

fledge-iot / fledge

An open source platform for the Industrial Internet of Things, it acts as an edge gateway between sensor devices and cloud storage systems.
https://www.lfedge.org/projects/fledge/
Apache License 2.0
117 stars 43 forks source link

FOGL-8753 : Implemented user blocking for incorrect password #1397

Closed gnandan closed 3 weeks ago

ashish-jabble commented 1 month ago

Audit API tests are also failing with the given change

ashish-jabble commented 1 month ago

VERSION file is also missing. It should be with version 72

praveen-garg commented 1 month ago

@mshariq-nerd Please test and review per GUI needs so that we can expedite merge.

mshariq-nerd commented 1 month ago

@gnandan, As per Jira

Add an alert whenever an account is blocked for 24 hours.

This seems to be missing. Alert Manager shows this?

mshariq-nerd commented 1 month ago

@gnandan What will happen of a active session if logged in with same credentials in different browser? For example A user already logged in a browser X and try to login into the same account from the different browser Y, multiple times Or someone login impersonating me from Y browser now user will be blocked at X browser? cc/ @MarkRiddoch

MarkRiddoch commented 1 month ago

@gnandan What will happen of a active session if logged in with same credentials in different browser? For example A user already logged in a browser X and try to login into the same account from the different browser Y, multiple times Or someone login impersonating me from Y browser now user will be blocked at X browser? cc/ @MarkRiddoch

Any existing login by the user should not be affected by the blocking the user.