Merge rider-test-runner branch to master?

fledware / GodotXUnit

MIT License

32 stars 5 forks source link

Merge rider-test-runner branch to master? #14

Closed van800 closed 2 years ago

van800 commented 3 years ago

https://github.com/fledware/GodotXUnit/tree/rider-test-runner

rexfleischer commented 3 years ago

Sorry, there's an issue I'm trying to work through with this, I just haven't been able to get to it again. The issue is that the CI doesn't seem to find tests, and if they do, they don't run and timeout.

here for example: https://github.com/fledware/GodotXUnit/runs/4023521949

Execute Tests here doesn't find any tests
Execute Failing Integration Tests hangs

I'm pretty sure this issue is with how tests are loaded, but I can't seem to find it. Maybe it's related to the error about not finding metadata?

van800 commented 3 years ago

I can reproduce that locally in 10-20 attempts and even attach debugger. But I can't get, what is wrong. XUnit AssemblyRunner just doesn't send us any messages after the discovery. At the same time for example GodotXUnitRunnerBase._Process is called just fine.

rexfleischer commented 3 years ago

Oh, nice. You go the debugger working!

That's a good bit of info you gave. I'll try to get around to this by next week. I have the entire next week off from work so I should be able to dive into this.

rexfleischer commented 2 years ago

Got this merged. Thanks and good job!

rexfleischer commented 2 years ago

XUnit is definitely compatible for VS2019. And the rider compatibility doesn't change the underline process. The rider changes generally only changes how the tests are gathered and bootstrapped within the rider IDE.