This pull request introduces several refactorings, enhancements, and fixes across the event and calendar services. The changes aim to improve code readability, performance, and functionality, while also addressing existing bugs and updating localization features.
Summary of Changes
Refactoring
Authentication and Event Services:
Refactored AuthenticationServiceImpl, CacheKeyService, EventServiceImpl, and MfaServiceImpl to improve code structure and performance.
Added methods to EventServiceImpl:
getEventAttendeeRequestsToJoinEvent(): Retrieves search results for attendees requesting to join an event or stream.
setAttendeeRequestToJoinPendingIfStreamIsPrivate(): Manages attendee requests for private streams.
findStream(): Facilitates stream retrieval.
Updated domain, DTO, and enum classes to enhance encapsulation and reduce redundancy.
Localization
Replaced DeleteResponse with DeleteCalendarResponse in CalendarService.deleteCalendar().
Added message keys in calendar event response classes and updated message source files (messages_en_US.properties and messages_fr.properties).
Updated response classes to use localized messages.
Bug Fixes and Improvements
Fixed existing and potential bugs, including issues in response and DTO classes.
Refactored FleenStreamRepository to search only for events with an active status.
Addressed bugs related to event attendee lists and retrieval of created event IDs in GoogleCalendarEventService.
Calendar and Country Services
Added methods in CountryServiceImpl for caching countries and managing cache updates.
Added method in CountryService to retrieve country codes.
Updated CalendarService.deleteCalendar() to use the new DeleteCalendarResponse.
Code Updates
Updated request body validation in DTOs (CreateCalendarEventDto, CreateLiveBroadcastDto, CreateStreamDto).
Renamed path variables in EventController from id to eventId and updated controller methods accordingly.
Updated EventVisibility enum with an of() method for string-to-enum conversion.
Documentation
Added documentation and reference links in CalendarConfiguration.
Provided additional comments and descriptions for methods and parameters.
Testing
Ensure that all new and updated methods are covered by tests.
Verify that localization changes are correctly applied and that messages are resolved based on the user's locale.
Test the functionality of new methods and fixes to confirm they work as expected.
Notes
Review the refactored code for consistency and performance improvements.
Ensure all related documentation is up-to-date and accurately reflects the changes made.
Overview
This pull request introduces several refactorings, enhancements, and fixes across the event and calendar services. The changes aim to improve code readability, performance, and functionality, while also addressing existing bugs and updating localization features.
Summary of Changes
Refactoring
AuthenticationServiceImpl,CacheKeyService,EventServiceImpl, andMfaServiceImplto improve code structure and performance.EventServiceImpl:getEventAttendeeRequestsToJoinEvent(): Retrieves search results for attendees requesting to join an event or stream.setAttendeeRequestToJoinPendingIfStreamIsPrivate(): Manages attendee requests for private streams.findStream(): Facilitates stream retrieval.Localization
DeleteResponsewithDeleteCalendarResponseinCalendarService.deleteCalendar().messages_en_US.propertiesandmessages_fr.properties).Bug Fixes and Improvements
FleenStreamRepositoryto search only for events with an active status.GoogleCalendarEventService.Calendar and Country Services
CountryServiceImplfor caching countries and managing cache updates.CountryServiceto retrieve country codes.CalendarService.deleteCalendar()to use the newDeleteCalendarResponse.Code Updates
CreateCalendarEventDto,CreateLiveBroadcastDto,CreateStreamDto).EventControllerfromidtoeventIdand updated controller methods accordingly.EventVisibilityenum with anof()method for string-to-enum conversion.Documentation
CalendarConfiguration.Testing
Notes