fleencorp / fleen-feen

Fleen Feen connects you with the world
GNU General Public License v3.0
0 stars 1 forks source link

Title: Created Unit test for Country #56

Closed adeniranjohn closed 1 month ago

adeniranjohn commented 1 month ago

As assigned on Issue

adeniranjohn commented 1 month ago

@aalamu give a check if it addresses the above

adeniranjohn commented 1 month ago

@aalamu Issues resolved

aalamu commented 1 month ago

@aalamu Issues resolved

I'll go through it.

adeniranjohn commented 1 month ago

@aalamu It would be helpful if you could check all the errors and highlight them at once for correction.

aalamu commented 1 month ago

@adeniranjohn We cannot find all the problems at once, so we refactor one thing and then we find the next thing to refactor.

  1. We need to push to feature/fleenfeen-24 as indicated in the issue because each issue is linked to a branch for we to work on.
  2. We need a better PR description for our implementation like

Title: Created Unit test for Country

Description

Created unit test for Country

  1. Ensured all test methods were refactored from camel case to snake case pattern

  2. Changed from Lombok builder to simple Java Object instantation pattern to make test codes agnostic and independent of a third party library.

  3. If we are testing just an id in a @Test case, we can just write

Country country = new Country();
country.setCountryId(1L);

and then test for the assertion. We do not need to set other argument if we're testing them in a specific @Test case.