fleetio / dbt-segment

Data models for Segment built using dbt (getdbt.com).
https://hub.getdbt.com/dbt-labs/segment/latest/
Apache License 2.0
11 stars 7 forks source link

BigQuery fix cast issue in segment_web_page_views #20

Closed Klimmy closed 4 months ago

Klimmy commented 6 months ago

Description & motivation

This solves the issue #18 (compatibility with BigQuery). I replaced cast with dbt.safe_cast macro for cross-database support.

Environment where it's been tested:

I tested it against Snowflake and BigQuery. I don't currently have access to Segment data, so I tested this specific line on non-segment data. The result is as expected, though — it generates a string column with 'segment_page_views_table' value.

Checklist

Klimmy commented 6 months ago

Hey @0adamjones, do you think you can review this one?

Klimmy commented 5 months ago

Hey folks, @jmhollinger, @lindseywatts, @blake-im-lyka, @robsberg, real sorry for bothering, but here is the small fix waiting for the review. It will make this package compatible with BigQuery. Could you help with reviewing it?

0adamjones commented 4 months ago

Hey @Klimmy so sorry! Didn't see this until just now. I'm going to review this now.

AgustinBanchio commented 3 months ago

Hi, has this been released into a new version? We are facing this same issue

0adamjones commented 3 months ago

@AgustinBanchio Hey there! Sorry for the trouble, I forgot to put out the new release. Check out 0.4.0!