fleetyards / fleetyards

A Ship Database and Web API based on the official Star Citizen Ship Matrix.
https://fleetyards.net
GNU General Public License v3.0
50 stars 10 forks source link

Bug: Wrongfully Attributed Loaners in Fleet View (Resolved by Removing and Re-Adding Ships to Hangar) #2469

Open James-MacIntyre opened 1 year ago

James-MacIntyre commented 1 year ago

Hello, it's me again! When I tested to see if the loaner filter was fixed I noticed that all the loaners on the list were considered to be commanded by myself (Dragoon47) in our usual fleet: https://fleetyards.net/fleets/candymountainblade/ships/

In addition, they were loaners from unpurchased ships, but more amusingly when I removed my ships from the fleet we had no loaners that showed up at all.

Seeing this, Wang_Fang set his fleet filter to All Purchased Ships and the loaners from his purchased ships (As opposed to my unpurchased ones) then showed in the fleet view.

I tried removing all my ships and re-adding them to see if there's any legacy to the bug that can be cleared.

Removing all ships from my fleet and re-adding them seemed to fix whatever was causing this, and the fleet now only shows loaners from purchased ships, even when adding only unpurchased ships in separate hangar groups.

mortik commented 1 year ago

Thats strange, i fixed an issue where updates to the hangar were not correctly copied to the users fleets. After that all fleet memberships were updated and should have resolved the issues you had. That was on 26. of December. Loaners and Hangar Groups are currently a separated issue since loaners are not attached to any hangar groups. I don't know when or if i will be able to fix this because of the underlying loaner system this issue gets very complicated.