flekschas / jupyter-scatter

Interactive 2D scatter plot widget for Jupyter Lab and Notebook. Scales to millions of points!
https://jupyter-scatter.dev
Apache License 2.0
392 stars 17 forks source link

axes tick labels are not updated after changing x or y #127

Closed abast closed 2 months ago

abast commented 5 months ago
jscatter.__version__ 
>'0.15.1'
# create data frame with 3 columns that require different scaling
df = pd.DataFrame([[1,2,3],[1,2,3],[10,20,100]], index = ['a', 'b', 'c']).T
# initial scatter plot is rendered correctly
s = Scatter(data = df, x = 'a', y = 'b')
s.show()

initial scatter plot is rendered correctly

image

Afterwards, change x to column c. This does not update the axis, resulting in an incorrect plot:

s.x('c')

After changing x to column c, the xticks are not updated and are incorrect.

image
flekschas commented 5 months ago

Already fixed in #125 :)

flekschas commented 5 months ago

But thanks a lot for reporting! 🙏 I'll merge the bug fix PR today and should be able to cut a release with the fixes soon.

abast commented 5 months ago

Fantastic!

abast commented 2 months ago

This is fixed, right?

flekschas commented 2 months ago

I think so