search

flekschas / svelte-simple-modal

A simple, small, and content-agnostic modal for Svelte v3 and v4
https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313
MIT License
422 stars 30 forks source link

Support Svelte v4 in peerDepenencies #100

Closed mcmxcdev closed 1 year ago

mcmxcdev commented 1 year ago

Svelte v4 has just been released: https://github.com/sveltejs/svelte/releases/tag/svelte%404.0.0

It would be great to test and then update the allowed peerDepenencies range to include v4: https://github.com/flekschas/svelte-simple-modal/blob/master/package.json#L39-L41

flekschas commented 1 year ago

Good idea! I'll try to do some testing over the next days. If you have the time to also give it a try with svelte v4 that'd be much appreciated.

flekschas commented 1 year ago

Here's a PR fixing the peer dependency: https://github.com/flekschas/svelte-simple-modal/pull/101

If you have the chance, please give it a test.

mcmxcdev commented 1 year ago

Hey @flekschas, I tested my application with the latest commit of the Svelte 4 PR and it works great!

image

I would say the PR is ready to get merged :smile: