search

flekschas / svelte-simple-modal

A simple, small, and content-agnostic modal for Svelte v3 and v4
https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313
MIT License
422 stars 31 forks source link

Update to support Svelte v4 #101

Closed flekschas closed 1 year ago

flekschas commented 1 year ago

This PR updates svelte-simple-modal to work with Svelte v4. This PR also updates a bunch of third-party dev libraries.

Fixes #100 Fixes #102

Currently Observed Behavior

Currently, the peer dependency prevents a normal usage of svelte-simple-modal with Svelte v4.

New Behavior

With the updating of the peer dependency. svelte-simple-modal can be installed with v4 without any warnings.

Note that functionally, everything already works with v4. See the demo below:

Demo: https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313?version=4.0.0

flekschas commented 1 year ago

According to https://github.com/flekschas/svelte-simple-modal/issues/100#issuecomment-1607390783, https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313?version=4.0.0, and my internal tests this PR should successfully add support for v4.