search

flekschas / svelte-simple-modal

A simple, small, and content-agnostic modal for Svelte v3 and v4
https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313
MIT License
422 stars 31 forks source link

Svelte 4 Compatibility issues #103

Closed revers3ntropy closed 1 year ago

revers3ntropy commented 1 year ago

Everything seems to work, only vite complains:

[vite-plugin-svelte] WARNING: The following packages use a svelte resolve configuration in package.json that has conflicting results and is going to cause problems future.

svelte-simple-modal@1.6.0

Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#conflicts-in-svelte-resolve for details.
flekschas commented 1 year ago

Weird. When you look at the package.json you'll see that svelte-simple-modal uses the Svelte export condition. Not sure what causes this warning.

Which version of Vite and vite-plugin-svelte are you using?

revers3ntropy commented 1 year ago 
$ vite -v
vite/4.3.9 linux-x64 node-v18.0.0

And in package.json:

...
"@sveltejs/vite-plugin-svelte": "^2.4.2"
...
"vite": "^4.3.9",
...

Which I am pretty sure is the latest versions of everything...

flekschas commented 1 year ago

Warning should be gone in v1.6.1

revers3ntropy commented 1 year ago

Yep looks good, thanks so much!