search

flekschas / svelte-simple-modal

A simple, small, and content-agnostic modal for Svelte v3 and v4
https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313
MIT License
422 stars 31 forks source link

100vh height gets cut off on android browsers #40

Closed austinwritescode closed 3 years ago

austinwritescode commented 3 years ago

The modal is too tall on android browsers and gets cut off on the bottom toolbar. Restyling the window and bg from 100vh to 100% units solved the issue for me. Perhaps that should be the default behavior?

flekschas commented 3 years ago

Could you attach a screenshot to illustrate the issue? I don't have an android device so I can't test this but in general 100vh seems reasonable as it should literally cover 100% of the available window height.

flekschas commented 3 years ago

If you have the chance, can you do me a favor and test this version here:

https://svelte.dev/repl/8df637ead30740bb9e8c9022df3cc11d?version=3.38.2

This should fix the issue.