search

flekschas / svelte-simple-modal

A simple, small, and content-agnostic modal for Svelte v3 and v4
https://svelte.dev/repl/b95ce66b0ef34064a34afc5c0249f313
MIT License
422 stars 30 forks source link

`console.log('furz')` #50

Closed seriousManual closed 3 years ago

seriousManual commented 3 years ago

this was probably a mistake right? ;)

https://github.com/flekschas/svelte-simple-modal/blob/master/src/Modal.svelte#L180

flekschas commented 3 years ago

Haha good catch! Having an easteregg in the source code can hurt right? 🤔😅

Removed it via b7fbd97. Thanks for finding and reporting it.

seriousManual commented 3 years ago

it suddenly showed up in the console in on of our projects 🤷‍♂️ let's hope that not too many german speakers saw your little easteregg 🤭

flekschas commented 3 years ago

The good thing is it made me check the ESLint rules again. I thought I already forbid console.log statements to be committed but it turns out I did not. Oh well, now they are forbidden.

Apologies again, and a new version is just published that removes the log statement.

seriousManual commented 3 years ago

no worries!