flerovious / pe

0 stars 0 forks source link

Adding universities are case sensitive #3

Open flerovious opened 2 years ago

flerovious commented 2 years ago

Screenshot 2021-11-12 at 4.29.46 PM.png

Although it is possible to add "University of California", it is not possible to add "University Of California", which is strange because the find command is case insensitive.

soc-pe-bot commented 2 years ago

Team's Response

The program is designed to be case sensitive for the add command, so there is no issue here. Furthermore, one can add using the University index. For the find command, it is case insensitive for the users convenience, and they can use the find command to get the correct name.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I understand the rationale for case insensitivity for the find command, but doesn't it apply to the add command too? Also, according to the module website, this qualifies as duplicate detection as seen in the screenshot below.

Screenshot 2021-11-18 at 8.55.36 PM.png Screenshot 2021-11-18 at 8.59.19 PM.png

Furthermore, the case insensitivity design decision mentioned above for either commands was not specified in the UG nor in the DG.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: It can be fairly common for users to write the name of the university in a different casing format. Throwing an error might confuse the user as to whether they are using the app correctly or not.