flerovious / pe

0 stars 0 forks source link

Removing module doesn't delete mapping completely #5

Open flerovious opened 2 years ago

flerovious commented 2 years ago

Screenshot 2021-11-12 at 5.06.10 PM.png

Originally, uni 75 was mapped to mod 1. After removing mod 1, search map has deleted the record. But the "list /suni" command which lists the universities and module mappings in your list hasn't removed the mapping yet

nus-se-bot commented 2 years ago

Team's Response

As per the user guide, removing a module does not remove the mappings associated with it, in order to aid the user. This is as intended.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The remove /mod command was performed, not the remove /map command which removes the link between a selected module and selected university.

If a user removes a module, they don't want to map it to any university anymore so it's expected that any links between the deleted module and the selected universities to be destroyed as well. Imagine a user linking a module MODULE_A to 10 universities then decides to remove it (for some reason like they prefer taking the mod at NUS instead of other schools). Deleting all the mappings one by one manually even though the module has been removed from the selected modules makes the user experience quite painful. Especially if for some reason they forget to delete and were led to thinking they'll be taking the module after making more mappings.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: Reason specified above, reproduced below:

The remove /mod command was performed, not the remove /map command which removes the link between a selected module and selected university.

If a user removes a module, they don't want to map it to any university anymore so it's expected that any links between the deleted module and the selected universities to be destroyed as well. Imagine a user linking a module MODULE_A to 10 universities then decides to remove it (for some reason like they prefer taking the mod at NUS instead of other schools). Deleting all the mappings one by one manually even though the module has been removed from the selected modules makes the user experience quite painful. Especially if for some reason they forget to delete and were led to thinking they'll be taking the module after making more mappings.