CDJ-900 compatibility - Githubissues

flesniak / python-prodj-link

A python interface to Pioneer ProDJ Link

Apache License 2.0

141 stars 26 forks source link

CDJ-900 compatibility #29

Open alcoralcor opened 1 year ago

alcoralcor commented 1 year ago

Hello, This tool seems impressive. I used latest master clone. It's nearly working with CDJ-900 and could be a game changer for these players that have a really olskool screen (no BPM decimal, waveform unusable, no zoomed waveform, no bars, etc). I have no other hardware to test with but with these CDJ-900 :

Elapsed/Remain stay at 00:00,
Bars are not working,
Waveform scroll is buggy : as soon as we use pitch, jog bend, play/pause, etc, scroll is reset to position 0,
and full waveform does not indicate position, neither hot cues. I launched the --dump-packets and get these logs that may help you, because lots of previous missing informations seem available in these packets. I remember only pressing start and then stop about 10 seconds later. 20230725_start_stop.txt

brunchboy commented 1 year ago

If you are talking about an actual pre-nexus CDJ-900, then unfortunately those players simply do not send the information required to support most features. It was the nexus line which first added the necessary data. If that is the player you are working with then unfortunately neither this project nor any other Pro DJ Link implementation will be able to provide the information you want. You’ll need to find a player that is nexus or newer.

alcoralcor commented 1 year ago

Ok. Sad news. But this project supports cdj 2000, (pre-nexus), this player was releases before cdj-900. And just take a look at the dump, it may be interesting.

brunchboy commented 1 year ago

Pre-nexus CDJ-2000s have exactly the same limitations as pre-nexus CDJ-900s.

brunchboy commented 1 year ago

I’m not a developer on this project, so I’m not going to be looking at the dumps. I coordinate the research and documentation for all the open source projects that work with the protocol, https://djl-analysis.deepsymmetry.org/djl-analysis/packets.html (as well as having several of my own that do cool things with the data).

brunchboy commented 1 year ago

The section on the CDJ status packets explains what data is missing for pre-nexus players.

alcoralcor commented 1 year ago

Thank you for your expertise and sorry for wanting to insist. Your work is very valuable and well documented. So there is nothing to do. The support for cdj-2000 may be remove (or limitations explained) from the readme. I close this issue.

brunchboy commented 1 year ago

No worries, I was not angry, I was just trying to share more information. (The details of what features can work with what players is quite confusing.) The developer may agree with your suggestions about the readme when he has a chance to review the discussion.