flet-dev / flet

Flet enables developers to easily build realtime web, mobile and desktop apps in Python. No frontend experience required.
https://flet.dev
Apache License 2.0
9.43k stars 360 forks source link

Rename `NavigationDestination` to `NavigationBarDestination` + some type hinting #3161

Closed bleudev closed 2 weeks ago

bleudev commented 2 weeks ago

Checklist:

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

FeodorFitsner commented 2 weeks ago

125 files changed? 😳 It's distracting from core functionality. Could you disable your formatting (or whatever is that) please?

bleudev commented 2 weeks ago

125 files changed? 😳 It's distracting from core functionality. Could you disable your formatting (or whatever is that) please?

i just moved OptionalNumber to types.py :) I needed to change every import of OptionalNumber from control.py. After changing i just use formatter for arrange the imports in alphabetical order.

bleudev commented 2 weeks ago

125 files changed? 😳 It's distracting from core functionality. Could you disable your formatting (or whatever is that) please?

i just moved OptionalNumber to types.py:) I needed to change every import ofOptionalNumberfromcontrol.py. After changing i just use formatter for arrange the imports in alphabetical order.

sorry for having to check all these 125 files for errors, but among them only in navigation_bar.py, navigation_drawer.py, navigation_rail.py and in control.pythere have been major changes

FeodorFitsner commented 2 weeks ago

It would be great if you could re-do the PR with only files changed that are relevant to your PR.

bleudev commented 2 weeks ago

It would be great if you could re-do the PR with only files changed that are relevant to your PR.

Ok. I'll do this