Open bleudev opened 2 weeks ago
@ndonkoHenri Do i can merge your pull (#3053) into my pull (write your code to my pull)? then it will be more convenient. Author of project will have to merge only my pull
@FeodorFitsner Can you review this PR?
@ndonkoHenri Do i can merge your pull (#3053) into my pull (write your code to my pull)? then it will be more convenient. Author of project will have to merge only my pull
Let's keep everything separate. It eases review.
@ndonkoHenri Do i can merge your pull (#3053) into my pull (write your code to my pull)? then it will be more convenient. Author of project will have to merge only my pull
Let's keep everything separate. It eases review.
I have already implemented this :)
I have already implemented this
Alright, didn't see that before. Please next time let's keep things separate when possible :)
Furthermore, Autoupdate is actually still in discussion, reason why I didn't wrap it up.
I have already implemented this
Alright, didn't see that before. Please next time let's keep things separate when possible :)
Furthermore, Autoupdate is actually still in discussion, reason why I didn't wrap it up.
When my pull will be merged, your features will also be merged. Can you review my pull for to make it happen faster?
@bleudev, @ndonkoHenri So this PR is based on a branch from https://github.com/flet-dev/flet/pull/3053?
@bleudev, @ndonkoHenri So this PR is based on a branch from #3053?
No, i just implemented features from henri's pull and added my features
@bleudev, @ndonkoHenri So this PR is based on a branch from #3053?
No, i just implemented features from henri's pull and added my features
More accurately, i just use he's idea, but code is mine
@FeodorFitsner
Checklist:
[x] Rename
NavigationDesttination
toNavigationBarDestination
(#3102)[x] Type hinting:
navigation_bar.py
,navigation_drawer.py
,navigation_rail.py
cupertino_navigation_bar.py
page.py
control.py
[x] Move
OptionalNumber
totypes.py
[x]
page.py
:close_snack_bar() method
Page.close_...()
methodsshow_...()
toopen_...()
[x] #3053 + my own features:
auto_update
property forPage
auto_update
add()
method,insert()
method,remove()
method,add()
,insert()
,remove()
are realised forNavigationBar
,NavigationDrawer
,NavigationRail
,CupertinoNavigationBar
,View
,Column
,Row
,MenuBar
,SearchBar
,AppBar
[x] Magic methods:
Contrrol in Page
andControl in View
+
,+=
control[n] = ...
-
,-=
[x]
isort
andblack
formatting(closes #3173) (closes #3053) (reopen of #3161)
It should be merged with #281