flet-dev / flet

Flet enables developers to easily build realtime web, mobile and desktop apps in Python. No frontend experience required.
https://flet.dev
Apache License 2.0
9.43k stars 360 forks source link

[reopen] Rename `NavigationDestination` to `NavigationBarDestination` + some type hinting, fixes and new features #3172

Open bleudev opened 2 weeks ago

bleudev commented 2 weeks ago

Checklist:

(closes #3173) (closes #3053) (reopen of #3161)

It should be merged with #281

bleudev commented 2 weeks ago

@ndonkoHenri Do i can merge your pull (#3053) into my pull (write your code to my pull)? then it will be more convenient. Author of project will have to merge only my pull

bleudev commented 1 week ago

@FeodorFitsner Can you review this PR?

ndonkoHenri commented 1 week ago

@ndonkoHenri Do i can merge your pull (#3053) into my pull (write your code to my pull)? then it will be more convenient. Author of project will have to merge only my pull

Let's keep everything separate. It eases review.

bleudev commented 1 week ago

@ndonkoHenri Do i can merge your pull (#3053) into my pull (write your code to my pull)? then it will be more convenient. Author of project will have to merge only my pull

Let's keep everything separate. It eases review.

I have already implemented this :)

ndonkoHenri commented 1 week ago

I have already implemented this

Alright, didn't see that before. Please next time let's keep things separate when possible :)

Furthermore, Autoupdate is actually still in discussion, reason why I didn't wrap it up.

bleudev commented 1 week ago

I have already implemented this

Alright, didn't see that before. Please next time let's keep things separate when possible :)

Furthermore, Autoupdate is actually still in discussion, reason why I didn't wrap it up.

When my pull will be merged, your features will also be merged. Can you review my pull for to make it happen faster?

FeodorFitsner commented 1 week ago

@bleudev, @ndonkoHenri So this PR is based on a branch from https://github.com/flet-dev/flet/pull/3053?

bleudev commented 1 week ago

@bleudev, @ndonkoHenri So this PR is based on a branch from #3053?

No, i just implemented features from henri's pull and added my features

bleudev commented 1 week ago

@bleudev, @ndonkoHenri So this PR is based on a branch from #3053?

No, i just implemented features from henri's pull and added my features

More accurately, i just use he's idea, but code is mine

bleudev commented 1 week ago

@FeodorFitsner