search

flet-dev / serious-python

Python runtime for Flutter apps
Apache License 2.0
212 stars 22 forks source link

Change gradle command executing shell to bash to make `pushd` and `popd` commands available #67

Closed taaaf11 closed 10 months ago

taaaf11 commented 10 months ago

I think we should use bash shell to execute copyCustomDist task because, pushd and popd commands are available in bash not in sh in https://github.com/flet-dev/serious-python/blob/.../build.gradle#L79

Should I make a pull request about this?

Related issue: flet-dev/flet#2516 .

FeodorFitsner commented 10 months ago

I think we need to get rid of pushd and popd at call because we cannot guarantee user machine has bash as well, right?

FeodorFitsner commented 10 months ago

Related as well: https://github.com/flet-dev/flet/discussions/2529