flet-dev / serious-python

Python runtime for Flutter apps
Apache License 2.0
188 stars 23 forks source link

cmake ARCHIVE_EXTRACT command #78

Open ivangermes opened 6 months ago

ivangermes commented 6 months ago

Used a CMake ARCHIVE_EXTRACT command that supports only from CMake 3.18. But required cmake version is 3.10 ( for linux ) or 3.14 ( for windows ).

This leads to embarrassing errors ( ubuntu 20.04 with out-of-box cmake version 3.16 ):

CMake Error at 
flutter/ephemeral/.plugin_symlinks/serious_python_linux/linux/CMakeLists.txt:25 
(file):
  file does not recognize sub-command ARCHIVE_EXTRACT

Unable to generate build files

Error building Flet app - see the log of failed command above.

CMake docs about ARCHIVE_EXTRACT: https://cmake.org/cmake/help/latest/command/file.html#archive-extract

ARCHIVE_EXTRACT usage: https://github.com/flet-dev/serious-python/blob/e44dff11516019060d4e37e7a4ab900750c0243c/src/serious_python_linux/linux/CMakeLists.txt#L25 https://github.com/flet-dev/serious-python/blob/e44dff11516019060d4e37e7a4ab900750c0243c/src/serious_python_windows/windows/CMakeLists.txt#L24

I suggest increase requirement version of cmake to 3.18. There will be a clearer error message. And it will also allow to learn the list_prepend function. Because list(TRANSFORM ..) and list(PREPEND..) will already be supported in cmake 3.18. E.g. here https://github.com/flet-dev/serious-python/blob/e44dff11516019060d4e37e7a4ab900750c0243c/src/serious_python/example/run_example/linux/flutter/CMakeLists.txt#L14

hasanelfalakiy commented 1 month ago

same issue

mkasajim commented 1 month ago

I am using CMake version 3.22.1, but I am also getting the same issue. How do I fix this?