search

fletcher / MultiMarkdown-4

This project is now deprecated. Please use MultiMarkdown-6 instead!
https://github.com/fletcher/MultiMarkdown-5
Other
306 stars 59 forks source link

windows: use basedir in shell (batch) scripts #59

Closed danieldc closed 10 years ago

danieldc commented 10 years ago

The windows scripts always assume the mmd is in the path. The fix is to use %dp0\multimarkdown instead of multimarkdown -- this way the tool will work when multimarkdown.exe is not in the path. (if you prefer, I can do a pull request: here are the changes https://github.com/danieldc/MultiMarkdown-4/commit/76ddb9511a274ee397fa480c101691906b3b8877)

Also, the windows script installer uses c:\windows\system32 -- does not work when user does not have full admin rights, and makes it harder for the portable use case. (it also breaks when the user did not installed windows in c:\windows, but that is rare -- the fix will be to use %SystemRoot%)

danieldc commented 10 years ago

Sorry, I screwed up the original changes -- if you decide to use them, please use this instead https://github.com/danieldc/MultiMarkdown-4/commit/81ce74f83041d2aeaf46c9e091d47c49588b1dcd

fletcher commented 10 years ago

I'll look at the commit for the batch scripts. It seems reasonable though. Thanks for suggesting that.

As for the installer location, I'm not highly motivated to go messing around with installer that's already created. For portable use cases, just use the portable version that's available instead of the installer. That's what it's there for.

danieldc commented 10 years ago

Thanks, Fletcher.

fletcher commented 10 years ago

Batch scripts have been changed and will be in the next release.