search

fletcher / c-sss

Implementation of Shamir's Secret Sharing in C
http://fletcher.github.io/c-sss/
Other
63 stars 24 forks source link

Remove included Makefile. #4

Closed brennonbrimhall closed 7 years ago

brennonbrimhall commented 7 years ago

The current Makefile only works on Windows.

CMake will generate native files for the selected build system. If you're using GCC, the generated Makefile will use GCC. If you're on macOS (like me), the generated Makefile will automatically use Clang instead.

fletcher commented 7 years ago

Actually, Windows is the only OS that I am not certain this Makefile does work for. I don't use a Windows machine for development, and compile any Windows software on Linux, and then install it on Windows for testing when necessary.

You don't have to use it, and can simply cd into the build directory, run cmake .. yourself with the options you need (assuming you remember them). But why bother? Use this to properly configure cmake, and then make again within the build directory.

But the Makefile works fine on macOS and *nix -- those are what I use.

F-

brennonbrimhall commented 7 years ago

My apologies. You're right; I jumped to conclusions when I noticed the MingGW toolchain specified.

However, it does seem odd to me to include a Makefile when you have a CMakeLists.txt file. I suppose that's somewhat meta though.