search

fletcher / peg-multimarkdown

An implementation of MultiMarkdown in C, using a PEG grammar - a fork of jgm's peg-markdown. No longer under active development - see MMD 5.
Other
525 stars 55 forks source link

Links in readme missing href #140

Closed pckujawa closed 11 years ago

pckujawa commented 11 years ago

Most hyperlinks show up as anchors <a> with no href attribute, so they don't lead anywhere. Running Chrome on 32-bit Win7.

fletcher commented 11 years ago

Can you be more specific?

pckujawa commented 11 years ago

LOL, and here I thought I was being specific. Well here's a screenshot of one of the links as I see it in Chrome on Win7 32-bit. Essentially, all of the links look ok but don't have href attributes so they don't lead anywhere. (Scratch that - the MacPorts link seems to be ok. Pretty much none of the rest are, though.)

screenshot

Does that help?

fletcher commented 11 years ago

I guess github flavored Markdown has some bugs. Works fine in MultiMarkdown. ;)

pckujawa commented 11 years ago

While that may be true, it would be a service to your users to provide real links on the github page. (And there must be a way, considering that the MacPorts link works.) Just a thought.

fletcher commented 11 years ago

Well, I went and cleaned up the source text since upcoming version of MMD Composer now supports elastic tabstops. And now the MacPorts link doesn't work either....

I'm sure you can also understand how it would be annoying for me to have to rewrite Markdown text files because github's Markdown implementation needs updating (and follows some of the same bugs in the original Markdown.pl). Especially after working for years on building my own implementation of a Markdown tool.

A few years ago I had briefly looked into what it would take to add MMD support to github's lightweight markup support, but I didn't have time to work on implementing it.

The bug here is with github's code, not my document. The problem appears to be that they don't allow tab characters between the link identifier and the URL, which are specifically allowed in the Markdown syntax page for reference style links.

pckujawa commented 11 years ago

Those elastic tabstops are a very cool idea! Bummer about github - maybe we can start a concerted effort to make them fix their implementation :)

On Mon, Dec 10, 2012 at 1:50 PM, Fletcher T. Penney - notifications@github.com < +github+pck+374cd93cd6.notifications#github.com@spamgourmet.com> wrote:

Well, I went and cleaned up the source text since upcoming version of MMD Composer now supports elastic tabstopshttp://nickgravgaard.com/elastictabstops/. And now the MacPorts link doesn't work either....

I'm sure you can also understand how it would be annoying for me to have to rewrite Markdown text files because github's Markdown implementation needs updating (and follows some of the same bugs in the original Markdown.pl). Especially after working for years on building my own implementation of a Markdown tool.

A few years ago I had briefly looked into what it would take to add MMD support to github's lightweight markup support, but I didn't have time to work on implementing it.

The bug here is with github's code, not my document. The problem appears to be that they don't allow tab characters between the link identifier and the URL, which are specifically allowed in the Markdown syntax page for reference style links.

— Reply to this email directly or view it on GitHubhttps://github.com/fletcher/peg-multimarkdown/issues/140#issuecomment-11216919.

fletcher commented 11 years ago

Probably the most reliable approach will be to get MMD (and possibly peg-markdown?) working with github's text processing code. This could potentially allow it to work in their wiki's, which would be great.

Some of the potential pieces that are necessary:

https://github.com/djungelvral/rpeg-multimarkdown

https://github.com/github/markup

If MMD(peg-multimarkdown) properly worked with ruby, and could then be added to the markup project, then github could merge that into their live code and enable README and wiki support for MultiMarkdown and the extra features that enables (tables, footnotes, etc).

I just don't have the time right now to dig into this myself, unfortunately ....

pckujawa commented 11 years ago

Maybe some enterprising software dev will take it on :)

On Mon, Dec 10, 2012 at 3:18 PM, Fletcher T. Penney - notifications@github.com < +github+pck+374cd93cd6.notifications#github.com@spamgourmet.com> wrote:

Probably the most reliable approach will be to get MMD (and possibly peg-markdown?) working with github's text processing code. This could potentially allow it to work in their wiki's, which would be great.

Some of the potential pieces that are necessary:

https://github.com/djungelvral/rpeg-multimarkdown

https://github.com/github/markup

If MMD(peg-multimarkdown) properly worked with ruby, and could then be added to the markup project, then github could merge that into their live code and enable README and wiki support for MultiMarkdown and the extra features that enables (tables, footnotes, etc).

I just don't have the time right now to dig into this myself, unfortunately ....

— Reply to this email directly or view it on GitHubhttps://github.com/fletcher/peg-multimarkdown/issues/140#issuecomment-11220967.