search

fletcher / peg-multimarkdown

An implementation of MultiMarkdown in C, using a PEG grammar - a fork of jgm's peg-markdown. No longer under active development - see MMD 5.
Other
523 stars 55 forks source link

Modifications for compiling under Arch Linux ARM #146

Closed krontzo closed 11 years ago

krontzo commented 11 years ago

The binary build using the master source code, under Arch Linux ARM running in a Raspberry Pi, gets cycled when comparing chars against ints.

It is only required to change the type of variables ch in line 144 and curchar in line 100 of the markdown.c file, for int instead of char. Replacing char for signed char would also work, but since getopt_long and fgetc expect int I choose the first option.

I know that the -fsigned-char directive of the gcc compiler would also do the trick; but I consider that the code should be as portable as possible, to avoid surprises in future platforms. My two cents.

I tested peg-mmd with the modifications in that platform and now it works great. Also, under Mac OSX Lion, peg-mmd keeps working.

So, would you please include those modifications, so that future releases would keep working with the Arch Linux ARM running in a Raspberry Pi?

I didn't see the point of creating a new branch only for this.

Thanks in advance.

fletcher commented 11 years ago

It might take me a while to look at this, but I will keep the issue open.

Thanks!

fletcher commented 11 years ago

Changed in MMD-4