search

fleury08 / prettifier

Simple application that makes your JSON/XML requests/responses prettier to read
GNU General Public License v3.0
10 stars 3 forks source link

Rounded corners added #33

Closed JeysonFlores closed 2 years ago

JeysonFlores commented 2 years ago

Hi @fleury08 I've noticed that you ported this app to eOS 6. Good work! When I was using it I noticed that it doesn't use rounded corners (which feels quite odd in Odin) so I decided to open this pull request to add them. Originally I wanted to make use of Hdy.Window but when I started looking at your code I realized I would had to make some big changes to your code base in order to achieve those rounded corners. However I remembered a trick; If you add a custom headerbar to a window (this app already had a custom headerbar) and you add the "rounded" CSS class to the window, it will have rounded corners (at least in Odin). This is the exact same trick I've used in Hasher and ElementaryCpp. Here's the result: image

Thanks for reading!

fleury08 commented 2 years ago

Hi, @JeysonFlores, thank you for this fix! I actually never noticed myself :smile:. I will fix It today and then merge new version to Appcenter.