search

flex-users / flex-iframe

IFrame component for Flex applications.
github.com/flex-users/flex-iframe
120 stars 63 forks source link

IFrame doesn't close when component is removed from displaylist when window shows scrollbars #95

Open nicoulaj opened 13 years ago

nicoulaj commented 13 years ago

Originally filed by Z.Ba...@gmail.com on 2009-11-30T11:46:34

What steps will reproduce the problem?

  1. go to http://sagada.tv/
  2. Set the window size to below 877px X 714px.
  3. open the iframe: click on "Want Vmail on your site?"
  4. when browser window size is below 877px X 714px - the opened IFrame will not be closed by the flash component when clicking on the close button.
  5. try the same, now with windows size larger than 877px X 714px - everything work as expected.

What is the expected output? What do you see instead? You expect the iframe to be closed when the component is removed from the displaylist. but when there are scrollbars, the iframe window doesn't close.

What version of Flex-IFrame are you using? On what operating system and which navigator (specify the version too)? latest version. all operating systems and browsers.

Please provide any additional information below, and a sample Flex 3 project reproducing the issue if possible.

nicoulaj commented 13 years ago

Updated by alistair.rutherford on 2009-12-02T18:36:38

I have tried this with Chrome and IE7 and it does not close the iframe at any point. This is not surprising since the iframe does not work within pop-ups such as your register dialog (at least not at the moment). None of the examples show this type of implementation. I am going to re-label this as a feature request since it is not a bug.

Removed label Type-Defect Removed label Priority-Medium Added label Type-Enhancement Added label Priority-Low

nicoulaj commented 13 years ago

Updated by Z.Ba...@gmail.com on 2009-12-02T21:25:27

Why would you say it doesn't work? Tested on all major browsers - IE, Chrome and FF - all are working well, except for when a scroll-bar appears.

I would gladly help fix or enhance this and contribute a patch - could you explain why is this different then the demos?

Thanks!

nicoulaj commented 13 years ago

Updated by Julien.N...@gmail.com on 2010-05-14T15:57:57

For short, this is the following feature request: "Remove the iframe when the component is removed from the display list".

Original ticket set status to Accepted (we converted to open)

nicoulaj commented 13 years ago

Updated by piemaste...@gmail.com on 2010-07-08T06:52:32

This may technically be a feature request, but it seems like a pretty serious failing to not remove the IFrame component if its parent is removed. The old version of the Flex IFrame seemed to do this properly, but that had other issues, so I upgraded to this one to fix them (which it seems to), but now it doesn't go away if I close the component BEFORE it's fully loaded.

For the record, if you let the page load and then close it, it goes away, but if you close it while it's loading, it only goes away until loading is complete, at which point it appears again. Any ideas of how I could at least hack around this for now?

nicoulaj commented 13 years ago

Updated by piemaste...@gmail.com on 2010-07-08T06:58:17

Sorry for all the posts, but if you comment out the invalidateDisplayList() call in IFrame.handleFrameLoad(), it won't show up if you've closed it before it loads. Possibly not the best way to go about it, but it's good enough for me.