flexagoon / rounded-window-corners

A GNOME extension that adds rounded corners to all windows
GNU General Public License v3.0
176 stars 6 forks source link

refactor!: port preferences to libadwaita #15

Closed garaevdi closed 1 month ago

garaevdi commented 1 month ago

Tried to keep it as faithful to the original as possible, but there are still some notes:

flexagoon commented 1 month ago

This looks awesome, thanks!

A few issues though:

  1. image This looks pretty weird on small window sizes. You should probably add a padding between the button and the text here and on the "custom" page.

  2. There is a noticeable lag when entering the custom shadow page

flexagoon commented 1 month ago

The linter errors are due to formatting. You should run npx biome format --write src/ on your code and also use the "Organize imports" LSP action.

garaevdi commented 1 month ago

@garaevdi LGTM. There is still lag when opening the shadow edit page though. Do you know what this may be related to?

I think this is mostly due to loading of the background picture. I thought about alternate ways to implement this, like use GdkPixbuf and maybe load image asynchronously, but this would be either as slow as it already is, there would be some kind of loading before the page is shown or the picture would pop afterwards.

The ultimate solution would be a complete removal of background image, but IMHO then this page will lose half of it's charm.

flexagoon commented 1 month ago

Thanks a lot for the contribution!