Closed garaevdi closed 1 month ago
This looks awesome, thanks!
A few issues though:
This looks pretty weird on small window sizes. You should probably add a padding between the button and the text here and on the "custom" page.
There is a noticeable lag when entering the custom shadow page
The linter errors are due to formatting. You should run npx biome format --write src/
on your code and also use the "Organize imports" LSP action.
@garaevdi LGTM. There is still lag when opening the shadow edit page though. Do you know what this may be related to?
I think this is mostly due to loading of the background picture. I thought about alternate ways to implement this, like use GdkPixbuf
and maybe load image asynchronously, but this would be either as slow as it already is, there would be some kind of loading before the page is shown or the picture would pop afterwards.
The ultimate solution would be a complete removal of background image, but IMHO then this page will lose half of it's charm.
Thanks a lot for the contribution!
Tried to keep it as faithful to the original as possible, but there are still some notes:
EditShadowPage
GTK complaining about something related to focus, but it works and so be itPaddingsRow
turned out, but I couldn't come up with something better. If you have any suggestion, I'd be happy to implement themResetPage
uses Adw.AlertDialog which was introduced in 1.5, but gnome-shell 45 usually comes only with 1.4. If this a no-no move, I can change it to Adw.MessageDialog