flexagoon / rounded-window-corners

A GNOME extension that adds rounded corners to all windows
GNU General Public License v3.0
227 stars 12 forks source link

Gnome 45 compatibility #21

Closed matiasendata closed 4 months ago

matiasendata commented 4 months ago

Some of us stay on the previous Fedora release and hold on to update for stability reasons. Fedora 39 uses Gnome 45 but the extension is set to work only on Gnome 46. The original extension never got officially released beyond Gnome 44. Can we add Gnome 45 compatibilty? From my testing it works well.

flexagoon commented 4 months ago

Gnome 45 support was dropped in https://github.com/flexagoon/rounded-window-corners/commit/61c326e3d6cba36fe3d07cf1c15e6c74d3f9abb1, you can read it's description for an explanation of the change.

If your system has the right Libadwaita version and preferences work fine (including the reset dialog), feel free to compile the extension yourself with GNOME 45 support enabled.

flexagoon commented 4 months ago

Also, Fedora 40 was released a month ago and hasn't had any major issues, so I'm not sure why you wouldn't update

matiasendata commented 4 months ago

I appreciate the feedback. As stated, stability is the priority. Projects like Universal Blue follow the same philosophy: (latest)-1.

flexagoon commented 4 months ago

Projects like Universal Blue follow the same philosophy: (latest)-1.

@matiasendata I don't think that's the case. I'm currently using a Universal Blue-based image, and their images are based on latest Fedora (Fedora 40 in this case)

matiasendata commented 4 months ago

If you rebase, by default it goes to the gts branch, not latest. Of course, you can specify any branch you want. I get your point though, at the end of the day the extension works anyway.