search

flexagoon / rounded-window-corners

A GNOME extension that adds rounded corners to all windows
GNU General Public License v3.0
176 stars 6 forks source link

fix: modals in overview #27

Open garaevdi opened 1 week ago

garaevdi commented 1 week ago

In the overview, each WindowPreview gets a copy of parent's effect to add additional shadow. But modal dialogs are placed within parent's WindowPreview, which in some cases would change the size of WindowPreview and lead to weird shadow. Since both main and modal windows already have rounded corners the only casualty of this patch is window shadow in the overview, which IMHO isn't really a big deal because it's already missing if window doesn't have rounded corners, for example maximized windows.

fixes #18

flexagoon commented 1 week ago

Also please format your code with biome to fix CI warnings

garaevdi commented 1 week ago

I'll convert it to draft for now, since with this PR in it's current state windowPreview without shadow effect is blurry and I think there is a way to fix it.