search

flexagoon / rounded-window-corners

A GNOME extension that adds rounded corners to all windows
GNU General Public License v3.0
227 stars 12 forks source link

Blurry apps in overview #36

Open amadeusp opened 2 months ago

amadeusp commented 2 months ago

The contents of application windows are blurry and fuzzy when displayed in GNOME 46.3.1's overview.

350312467-2674111e-5ffb-4b0b-a6aa-d9df152c9a39 350312497-87688ca8-431f-4853-bc53-2503a89dc170

cyrneko commented 2 months ago

can reproduce! I am gonna try to test a bunch of applications to verify where this behavior does and doesn't happen, to potentially further narrow down what kinds of windows are affected.

cyrneko commented 2 months ago

can reproduce! I am gonna try to test a bunch of applications to verify where this behavior does and doesn't happen, to potentially further narrow down what kinds of windows are affected.

well...after testing pretty much every scenario I can think of, from different versions of GTK to Wayland-Native and XWayland, games and browsers, it really does seem to just be GTK4 apps that are unaffected for...some reason

For reference, I am also using GNOME Shell 46.3.1

flexagoon commented 2 months ago

@cyrneko gtk4 apps are probably unaffected just because "skip Libadwaita applications" is enabled in extension settings

TylerLaBree commented 2 months ago

@flexagoon Can confirm on my machine. Thanks for your work on the project!

Screenshot of libadwaita application (settings) looking blurry. "Skip LibAdwaita applications" is toggled off.

Screenshot of libadwaita application (settings) looking sharp and clean. "Skip LibAdwaita applications" is toggled on.

Non libadwaita apps (tested with thunderbird) still look blurry with "Skip LibAdwaita applications" toggled on.

amadeusp commented 2 months ago

@flexagoon Can confirm on my machine. Thanks for your work on the project!

Screenshot of libadwaita application (settings) looking blurry. "Skip LibAdwaita applications" is toggled off.

Screenshot of libadwaita application (settings) looking sharp and clean. "Skip LibAdwaita applications" is toggled on.

Non libadwaita apps (tested with thunderbird) still look blurry with "Skip LibAdwaita applications" toggled on.

I think flexagoon meant that the only reason GTK4 apps were not blurry in our tests was because they were turned off via the "Skip LibAdwaita applications" setting.

Impasse52 commented 1 month ago

I'm experiencing the same behavior even without any scaling at all, on Gnome 46, Fedora 40.

BlackRabbit22 commented 3 weeks ago

I'm also experiencing this without any scaling. It affects both GTk3 and GTK4 applications.

konstantintutsch commented 2 weeks ago

I think this issue might be related to how large the windows are calculated to be scaled in the overview.

I've noticed, at least on my end, that the issue only occurs when two (or more) applications are opened on two (or more) different workspaces.

Here's a video showcasing this:

https://github.com/user-attachments/assets/1b65f044-dae8-4a03-9abe-f412eb11aed8

The extension might be calculating and rendering the size of each window in the overview across all workspaces, not separate for each workspace and it's windows.

flexagoon commented 2 weeks ago

@konstantintutsch the issue is caused by commit https://github.com/flexagoon/rounded-window-corners/commit/1c0e89cbfd42703f95b42aca3f91cc0e8fd237b4 and is explained in the description of that commit:

fix: display windows correctly in overview

Previously, when opening the overview, the corner rounding was removed from windows themselves and applied to window previews.

This prevented the windows from being slightly blurry, but after a Mutter update, the code that was handling this broke, and window preview sizes were calculated incorrectly.

This commit removes this behavior. It means that windows in overview will be a bit pixelated, but it isn't very noticeable, and certainly better than the windows being half transparent. Maybe the blurriness issue will be easier to fix in the future, after I refactor the codebase.

konstantintutsch commented 2 weeks ago

@flexagoon Ah okay, sorry to have bothered you. Thought this issue was still relevant 😅

flexagoon commented 2 weeks ago

@konstantintutsch no, you didn't bother me and the issue is indeed relevant, I just currently don't know how to fix it unfortunately

aunetx commented 1 week ago

This happens because of a bug in upstream GNOME (quite easy to reproduce, steps described in the issue I opened): https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7903

I've not yet understood how to hack beyond it, but if I find how I will tell you!

Neo-29 commented 1 week ago

This happens because of a bug in upstream GNOME (quite easy to reproduce, steps described in the issue I opened): https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7903

I've not yet understood how to hack beyond it, but if I find how I will tell you!

Here's my comment with the link to this post, if that might help... https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5746#note_2225883

flexagoon commented 1 week ago

I'm locking this since it's an upstream issue and it's up to Gnome to fix this

@aunetx please ping me somewhere else if you find a way to work around this