search

flexagoon / rounded-window-corners

A GNOME extension that adds rounded corners to all windows
GNU General Public License v3.0
215 stars 10 forks source link

Plz update for gnome 47 im begging you #45

Open EisregenHaha opened 3 days ago

EisregenHaha commented 3 days ago

i love ur work and this extension so much my desktop is unusable without it plz update im on my knees. this time i cant offer feet pics tho because you will actually do it

flexagoon commented 3 days ago

The latest commit already supports gnome 47, you can install it from GitHub actions using instructions in the readme. It just needs a few minor changes to pass EGO review. I promise I'll do it soon I'm just busy with school and work

flexagoon commented 3 days ago

Also there were no breaking changes in Gnome 47, so even if you don't install the git version the latest release should just work with gsettings set org.gnome.shell disable-extension-version-validation true

EisregenHaha commented 3 days ago

Also there were no breaking changes in Gnome 47, so even if you don't install the git version the latest release should just work with gsettings set org.gnome.shell disable-extension-version-validation true

ah thanks man, didnt think to try for the same reasons u listed

EisregenHaha commented 3 days ago

Also there were no breaking changes in Gnome 47, so even if you don't install the git version the latest release should just work with gsettings set org.gnome.shell disable-extension-version-validation true

so i just built it from source but the corners wont turn round? im on the fedora 41 beta and they just stay square and i get this error when trying to open the extension settings:

TypeError: this._cfg.keepRoundedCorners is undefined

Stack trace: @file:///home/eisregen/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/preferences/pages/general.js:57:45 pages@file:///home/eisregen/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/preferences/index.js:5:5 fillPreferencesWindow@file:///home/eisregen/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/prefs.js:23:28 _loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:39:24 async_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:24:14 ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:15:4 OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:138:33 asyncLaunchExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:125:14 _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35 _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34

flexagoon commented 3 days ago

so i just built it from source but the corners wont turn round? im on the fedora 41 beta and they just stay square and i get this error when trying to open the extension settings

Yeah, that's exactly why I said to install it from GitHub actions instead of building from source

EisregenHaha commented 3 days ago

so i just built it from source but the corners wont turn round? im on the fedora 41 beta and they just stay square and i get this error when trying to open the extension settings

Yeah, that's exactly why I said to install it from GitHub actions instead of building from source

sorry my bad 😔 , i was confused cuz turning validation off also resulted same. i'll close this issue when it works thanks

flexagoon commented 3 days ago

Please try installing it using gnome-extensions install and then tell me if the error still happens. I changed the settings schema a bit and it's supposed to automatically migrate, but it doesn't do that in some cases. It's fine if that only happens when building from source, but I want to know if it also happens with regular installation.

EisregenHaha commented 3 days ago

Please try installing it using gnome-extensions install and then tell me if the error still happens. I changed the settings schema a bit and it's supposed to automatically migrate, but it doesn't do that in some cases. It's fine if that only happens when building from source, but I want to know if it also happens with regular installation.

so yeah i just installed using actions and the same issue persists, i tried clean installing (dk if that makes a diff) but everything i tried leads to the same result.

radical4ever commented 3 days ago

Please try installing it using gnome-extensions install and then tell me if the error still happens. I changed the settings schema a bit and it's supposed to automatically migrate, but it doesn't do that in some cases. It's fine if that only happens when building from source, but I want to know if it also happens with regular installation.

tried the same thing, on regular install and got the same issue