flexagoon / rounded-window-corners

A GNOME extension that adds rounded corners to all windows
GNU General Public License v3.0
229 stars 12 forks source link

The extension does not work. #50

Closed cristian-home closed 1 week ago

cristian-home commented 1 week ago

The last update broke the extension.

imagen

imagen

TypeError: this._cfg.keepRoundedCorners is undefined

Stack trace:
  @file:///home/cristian/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/preferences/pages/general.js:57:9
  pages@file:///home/cristian/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/preferences/index.js:5:5
  fillPreferencesWindow@file:///home/cristian/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/prefs.js:23:28
  _loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:41:18
  async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:26:14
  ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:17:4
  OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
  async*LaunchExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:126:14
  _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
  _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
flexagoon commented 1 week ago

How did you install the extension? Did you update it from Gnome Extensions? Also, did you have a nightly version (built from source or from Github Actions) installed before that?

flexagoon commented 1 week ago

@cristian-home Please run the following command and provide the entire output here as a code block:

dconf dump /org/gnome/shell/extensions/rounded-window-corners-reborn/
cristian-home commented 1 week ago

Using the Extension Manager app by Matthew Jakeman, by logging out and logging in to update the extension.

https://flathub.org/apps/com.mattjakeman.ExtensionManager

flexagoon commented 1 week ago

@cristian-home please show the output of the command I wrote above

cristian-home commented 1 week ago

imagen

custom-rounded-corner-settings=@a{sv} {}
global-rounded-corner-settings={'padding': <{'left': <uint32 1>, 'right': <uint32 1>, 'top': <uint32 1>, 'bottom': <uint32 1>}>, 'keep_rounded_corners': <{'maximized': <false>, 'fullscreen': <false>}>, 'border_radius': <uint32 12>, 'smoothing': <uint32 0>}
settings-version=uint32 5
flexagoon commented 1 week ago

@cristian-home

uhh

I'm really not sure how this happened tbh, it was supposed to be fixed by 5d0eb93c0f9f91511a142f0aa7d0f0f3b61b4e9a and I can't reproduce this. Did you previously install the extension manually from source code or through a zip file?

For now, you can fix the issue by running:

dconf reset -f /org/gnome/shell/extensions/rounded-window-corners-reborn/
cristian-home commented 1 week ago

The command dconf reset -f /org/gnome/shell/extensions/rounded-window-corners-reborn/ fixed the problem, thanks.

flexagoon commented 1 week ago

Did you previously install the extension manually from source code or through a zip file?

@cristian-home ?

cristian-home commented 1 week ago

No, I had installed it yesterday from the https://extensions.gnome.org/ site via the Firefox extension, and it was updated today from the Extension Manager by Matthew Jakeman app.

boooooooaq commented 1 week ago

Same thing happened to me while updating today, installed the extension from extension manager a while back, the dconf command @flexagoon provided also fixed it for me.

bernoussama commented 1 week ago

The last update broke the extension.

imagen

imagen

TypeError: this._cfg.keepRoundedCorners is undefined

Stack trace:
  @file:///home/cristian/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/preferences/pages/general.js:57:9
  pages@file:///home/cristian/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/preferences/index.js:5:5
  fillPreferencesWindow@file:///home/cristian/.local/share/gnome-shell/extensions/rounded-window-corners@fxgn/prefs.js:23:28
  _loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:41:18
  async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:26:14
  ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:17:4
  OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
  async*LaunchExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:126:14
  _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
  _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

same here, happened after the update from extension manager

flexagoon commented 1 week ago

Can everyone who experiences this issue please attach the output of dconf dump /org/gnome/shell/extensions/rounded-window-corners-reborn/ to their comment?

bernoussama commented 1 week ago

output of dconf dump /org/gnome/shell/extensions/rounded-window-corners-reborn/:

[/]
border-color=(0.42964518070220947, 0.35815554857254028, 0.47333332896232605, 1.0)
border-width=1
global-rounded-corner-settings={'padding': <{'left': uint32 1, 'right': 1, 'top': 1, 'bottom': 1}>, 'keepRoundedCorners': <{'maximized': true, 'fullscreen': false}>, 'borderRadius': <uint32 12>, 'smoothing': <0.0>, 'enabled': <true>}
settings-version=uint32 5
skip-libadwaita-app=true

P.S: i did it after running this command dconf reset -f /org/gnome/shell/extensions/rounded-window-corners-reborn/

memory-colors commented 1 week ago

Same here :/

Dconf dump, as requested:

dconf dump /org/gnome/shell/extensions/rounded-window-corners-reborn/ [/] border-color=(0.094117648899555206, 0.098039217293262482, 0.11372549086809158, 1.0) border-width=3 custom-rounded-corner-settings=@a{sv} {} focused-shadow={'vertical_offset': 48, 'horizontal_offset': 0, 'blur_offset': 48, 'spread_radius': 50, 'opacity': 38} global-rounded-corner-settings={'padding': <{'left': <uint32 1>, 'right': <uint32 1>, 'top': <uint32 1>, 'bottom': <uint32 1>}>, 'keep_rounded_corners': <{'maximized': , 'fullscreen': }>, 'border_radius': <uint32 24>, 'smoothing': <0.40000000000000002>} settings-version=uint32 5 skip-libadwaita-app=false unfocused-shadow={'vertical_offset': 2, 'horizontal_offset': 0, 'blur_offset': 12, 'spread_radius': 4, 'opacity': 40}

Ego-X commented 1 week ago

dconf reset -f /org/gnome/shell/extensions/rounded-window-corners-reborn/ fixed the error.

flexagoon commented 1 week ago

A fixed version is pending review:

https://extensions.gnome.org/review/58730