flexdinesh / react-redux-boilerplate

A minimal React-Redux boilerplate with all the best practices
MIT License
782 stars 274 forks source link

Is It Server Side Rendering ? I think react-helmet doesn't work when changes page #4

Open gagahkharismanuary opened 6 years ago

gagahkharismanuary commented 6 years ago

Hi,

I tried your boilerplate and I used to see source page when changes page and it's not changed in the meta tag to support SEO

flexdinesh commented 6 years ago

@gagahkharismanuary We don't have any server side rendering here. We use react-helmet to take care of <meta> and all other tags in <head>.

Refer to this link for more info - react-helmet

chernysh commented 6 years ago

@flexdinesh Any plans to make it isomorphic?

flexdinesh commented 6 years ago

@chernysh This is interesting. Right now the whole app is client-centric. Absolutely zero server side logic at all. But it'd be great to make it isomorphic and configurable, meaning we should be able to turn server-side rendering on and off with one config variable.

oyeanuj commented 5 years ago

Also would be super interested in making this setup SSR-friendly! I feel like that is the last missing part to make this super useful for all kinds of projects..

northfoxz commented 5 years ago

Please, please don't make it isomophic, the point of this repository(to me) is to stay simple and focused.