search

flexera-public / right_aws

RightScale Amazon Web Services Ruby Gems
MIT License
451 stars 175 forks source link

Fix encoding of + in file keys. #115

Closed rbroemeling closed 12 years ago

rbroemeling commented 12 years ago

Fixes https://github.com/rightscale/right_aws/issues/114

tve commented 12 years ago

Mhh, it seems there are lots of places in that file that would have to be changed. Also, the encoding of '+' in S3 has historically been tricky and not 100% conformant to the RFCs. See https://forums.aws.amazon.com/thread.jspa?threadID=16361 for reference. Have you tested that what you're changing is correct?

rbroemeling commented 12 years ago

I have tested that it solves the particular issue that my company is running into, yes. I've also tested that it doesn't break anything within our operations. I have NOT tested whether it is correct for all cases, no.

I'll mention that basically all that the change entails is reverting https://github.com/rightscale/right_aws/commit/78d63f59c913546f371d5aa4eae1708267b25774 and then ensuring that we encode spaces correctly as '%20', rather than '+'.

konstantin-dzreev commented 12 years ago

this should be fixed now, thank you