search

flexera-public / right_aws

RightScale Amazon Web Services Ruby Gems
MIT License
451 stars 175 forks source link

regression in right_ec2_rbs #57

Closed neillturner closed 13 years ago

neillturner commented 13 years ago

in 2.0 it was describe_snapshots(list=[],owner=nil,restorable_by=nil) now in 2.1 it is: describe_snapshots(*list_and_options) Now i appreciate that you can use filters for the owner and restorable by but

  1. This will break existing code
  2. For eucalyptus that doesn't support filters yet so the functionality is lost.

Between versions you really need to keep the method signatures the same or extend them rather than breaking them....hope this is not too harsh...... but it would reduce folks cloning the code. Also releasing the ruby gem once a year is too slow. need to release at least every 6 months. 3 months would be even better.....

Neill

konstantin-dzreev commented 13 years ago

We have a fix for this and semantic for the call will be:

ec2.describe_snapshots(IDS_LIST, :restorable_by => ['123456781234'], :owner => ['self', 'amazon'], :filters => {'tag:MyTag' => 'MyValue'})

we will push the fix today or tomorrow

neillturner commented 13 years ago

you need to also do the option in :owner AWS Account ID so it should be :owner => ['self', 'amazon','123456781234']

konstantin-dzreev commented 13 years ago

yes, we do this, I just missed it in the example